Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3.1.0-specific words from the README #4168

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

lornajane
Copy link
Contributor

Minor update to the README to remove references to 3.1 as the current version and the markdown as the source of truth. There's more work to do in this file but removing the version inaccuracy seemed worth doing by itself.

Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe distinguish between "markdown sources" here and "published specs" over at https://spec.openapis.org/?

README.md Outdated Show resolved Hide resolved
ralfhandl
ralfhandl previously approved these changes Oct 30, 2024
@ralfhandl ralfhandl requested a review from a team October 30, 2024 12:49
mikekistler
mikekistler previously approved these changes Oct 30, 2024
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I left one comment on jargon.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lornajane lornajane dismissed stale reviews from mikekistler and ralfhandl via 6277bba October 31, 2024 14:02
@lornajane lornajane requested review from ralfhandl, handrews, mikekistler and a team October 31, 2024 14:03
ralfhandl
ralfhandl previously approved these changes Oct 31, 2024
handrews
handrews previously approved these changes Oct 31, 2024
@lornajane lornajane dismissed stale reviews from handrews and ralfhandl via 17aa9a5 October 31, 2024 17:21
@lornajane lornajane force-pushed the version-agnostic-readme branch from 6277bba to 17aa9a5 Compare October 31, 2024 17:21
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@handrews handrews merged commit 752fbf2 into OAI:main Oct 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants