Update 3.0.4 Spec for Style Values #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charjr
force-pushed
the
update-3-0-4-style-docs
branch
from
8f72236
to
46eca09
Compare
handrews
added
the
param serialization
karenetheridge
approved these changes
Mar 28, 2024
mikekistler
reviewed
Apr 4, 2024
versions/3.0.4.md
Outdated
Comment on lines
1057
to
1058
| spaceDelimited | `array`, `object` | `query` | Space separated array values. This option replaces `collectionFormat` equal to `ssv` from OpenAPI 2.0. | ||
| pipeDelimited | `array`, `object` | `query` | Pipe separated array values. This option replaces `collectionFormat` equal to `pipes` from OpenAPI 2.0. |
There was a problem hiding this comment.
Why add object for these two styles? If we decide that we want this then I think the description should explain what this style means for objects and not just arrays.
mikekistler
reviewed
Apr 4, 2024
versions/3.0.4.md
Outdated
Comment on lines
1057
to
1058
| spaceDelimited | `array`, `object` | `query` | Space separated array values. This option replaces `collectionFormat` equal to `ssv` from OpenAPI 2.0. | ||
| pipeDelimited | `array`, `object` | `query` | Pipe separated array values. This option replaces `collectionFormat` equal to `pipes` from OpenAPI 2.0. |
There was a problem hiding this comment.
As discussed in TSC mtg:
Suggested change
| spaceDelimited | `array`, `object` | `query` | Space separated array values. This option replaces `collectionFormat` equal to `ssv` from OpenAPI 2.0. | |
| pipeDelimited | `array`, `object` | `query` | Pipe separated array values. This option replaces `collectionFormat` equal to `pipes` from OpenAPI 2.0. | |
| spaceDelimited | `array`, `object` | `query` | Space separated array values or object properties. This option replaces `collectionFormat` equal to `ssv` from OpenAPI 2.0. | |
| pipeDelimited | `array`, `object` | `query` | Pipe separated array values or object properties. This option replaces `collectionFormat` equal to `pipes` from OpenAPI 2.0. |
There was a problem hiding this comment.
"array values or object properties and values"
There was a problem hiding this comment.
@mikekistler - this needs to be resolved before merged
This was referenced Apr 4, 2024
charjr
force-pushed
the
update-3-0-4-style-docs
branch
from
46eca09
to
2b3889f
Compare
karenetheridge
approved these changes
Apr 11, 2024
lornajane
approved these changes
Apr 17, 2024
ralfhandl
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3682