Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0.3 Callback Object - Key Expression - one-off-error in expression example #2167

Closed
ralfhandl opened this issue Feb 29, 2020 · 3 comments
Closed

3.0.3 Callback Object - Key Expression - one-off-error in expression example #2167

ralfhandl opened this issue Feb 29, 2020 · 3 comments
Assignees
@darrelmiller
Milestone
v3.0.4

Comments

@ralfhandl
Copy link
Contributor

The second-to-last entry in the examples table of section Key Expression should be

Expression Value
$request.body#/successUrls/1 http://clientdomain.com/medium

RFC6901 uses zero-based indexing, so 1 references the second item in an array.
@ralfhandl ralfhandl changed the title 3.0.3 Callback Object - Key Expression 3.0.3 Callback Object - Key Expression - one-off-error in expression example Feb 29, 2020
@MikeRalphson
Copy link
Member

Thanks. Do you have time to PR a change? We don't have an open 3.0.4 branch at the moment, but as this is the first time this has been noticed, I think it could just go into 3.1.0

@ralfhandl ralfhandl mentioned this issue Apr 28, 2022
Merged
@ralfhandl
Copy link
Contributor Author

ralfhandl commented Apr 28, 2022 •
edited
Loading

Ok, finally got around to it:

@darrelmiller please review.

Thanks in advance!

@ralfhandl ralfhandl mentioned this issue Apr 28, 2022
Closed
earth2marsh added a commit that referenced this issue Oct 13, 2022
@earth2marsh
Merge pull request #2920 from ralfhandl/v3.1.1-dev
a178f02 
Fix for #2167
@ralfhandl ralfhandl mentioned this issue Mar 6, 2023
Merged
darrelmiller pushed a commit that referenced this issue Mar 6, 2023
@ralfhandl
Fix for #2167 (#3189)
530637e 
Fixes #2167
@ralfhandl
Copy link
Contributor Author

Applied to 3.1.1-dev and 3.0.4-dev

charjr pushed a commit to charjr/OpenAPI-Specification that referenced this issue Apr 27, 2023
@ralfhandl @charjr
Fix for OAI#2167
fbdc5fd
charjr pushed a commit to charjr/OpenAPI-Specification that referenced this issue Apr 27, 2023
@ralfhandl @charjr
Fix for OAI#2167
b15951d
@handrews handrews added this to the v3.0.4 milestone May 22, 2024
@lornajane lornajane mentioned this issue Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darrelmiller darrelmiller

Labels
None yet
Projects
None yet
Milestone
v3.0.4
Development

No branches or pull requests
4 participants
@MikeRalphson @darrelmiller @ralfhandl @handrews