Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing default input file value in the cli #17

Merged
merged 1 commit into from
May 16, 2019

Conversation

NyanKiyoshi
Copy link
Owner

@NyanKiyoshi NyanKiyoshi commented May 16, 2019

Fixes #15.

Changes Checklist

  • The changes were tested (manually)
  • The changes are tested automatically (pytest)
  • The changes are optimized and clean
  • The changes are documented:
    • The code is documented
    • The readme is up to date
    • The documentation (readthedocs) is up to date and tested

@NyanKiyoshi NyanKiyoshi added bug Something isn't working cli labels May 16, 2019
@NyanKiyoshi NyanKiyoshi added this to the v1.0.0b1 milestone May 16, 2019
@NyanKiyoshi NyanKiyoshi self-assigned this May 16, 2019
@NyanKiyoshi NyanKiyoshi force-pushed the fix/cli/default-input-file branch 2 times, most recently from 4d08e5b to 412980f Compare May 16, 2019 15:50
@NyanKiyoshi NyanKiyoshi force-pushed the fix/cli/default-input-file branch from 412980f to fce6409 Compare May 16, 2019 15:56
@codecov-io
Copy link

codecov-io commented May 16, 2019

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #17   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         128    130    +2     
  Branches       13     13           
=====================================
+ Hits          128    130    +2
Impacted Files Coverage Δ
pytest_django_queries/plugin.py 100% <100%> (ø) ⬆️
pytest_django_queries/cli.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40ea13c...fce6409. Read the comment docs.

@NyanKiyoshi NyanKiyoshi merged commit a631dcf into master May 16, 2019
@NyanKiyoshi NyanKiyoshi deleted the fix/cli/default-input-file branch May 16, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CLI commands' input file argument should be optional
2 participants