TA#72203 [MIG][16.0] project_task_subtask_same_project #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majouda
reviewed
Jan 7, 2025
| res = super().write(vals) | ||
| for task in self: | ||
| if task.child_ids and "project_id" in vals: | ||
| task.child_ids.write({"project_id": vals["project_id"]}) |
There was a problem hiding this comment.
Hello @rivo2302
I tested this code, but it's not working.
I'm unsure whether to keep it or not since it's not mentioned in the README.
I don't understand how the unit tests are passing without any issues.
Could you please verify this?
majouda
reviewed
Jan 7, 2025
| class ProjectTaskSubtaskSameProject(models.Model): | ||
| _inherit = "project.task" | ||
|
|
||
| def _check_subtask_not_in_different_project(self): |
There was a problem hiding this comment.
Hello @rivo2302
It would be preferable to use @api.constrains here instead of calling the check in the write() method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.