Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass through AsyncRead and AsyncWrite traits #297

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Pass through AsyncRead and AsyncWrite traits #297

merged 1 commit into from
Oct 13, 2024

Conversation

link2xt
Copy link
Contributor

@link2xt link2xt commented Oct 12, 2024 •
edited
Loading

Closes #296

@link2xt link2xt mentioned this pull request Oct 12, 2024
Closed
@link2xt link2xt force-pushed the link2xt/passthrough-traits branch from 77e8717 to 8a36b7c Compare October 12, 2024 05:28
NobodyXu
NobodyXu requested changes Oct 12, 2024
View reviewed changes
src/tokio/bufread/generic/decoder.rs Outdated Show resolved Hide resolved
NobodyXu
NobodyXu requested changes Oct 12, 2024
View reviewed changes
src/tokio/bufread/generic/decoder.rs Outdated Show resolved Hide resolved
@link2xt link2xt mentioned this pull request Oct 12, 2024
Merged
NobodyXu
NobodyXu requested changes Oct 12, 2024
View reviewed changes
src/futures/bufread/generic/decoder.rs Outdated Show resolved Hide resolved
@link2xt link2xt force-pushed the link2xt/passthrough-traits branch 2 times, most recently from 75ce0af to 75b1398 Compare October 12, 2024 08:59
@link2xt link2xt changed the title Pass through AsyncWrite for tokio::bufread decoder Pass through AsyncRead and AsyncWrite traits Oct 12, 2024
@link2xt link2xt force-pushed the link2xt/passthrough-traits branch from 75b1398 to 4d90e5b Compare October 12, 2024 09:00
@link2xt link2xt marked this pull request as ready for review October 12, 2024 09:00
@link2xt
Copy link
Contributor Author

link2xt commented Oct 12, 2024

I haven't passed AsyncBufRead, let's save it for another PR if needed.

@link2xt link2xt force-pushed the link2xt/passthrough-traits branch from 4d90e5b to b98e46b Compare October 12, 2024 09:05
NobodyXu
NobodyXu requested changes Oct 12, 2024
View reviewed changes
src/futures/write/generic/decoder.rs Outdated Show resolved Hide resolved
src/futures/write/generic/encoder.rs Outdated Show resolved Hide resolved
src/futures/write/macros/decoder.rs Outdated Show resolved Hide resolved
src/futures/write/macros/encoder.rs Outdated Show resolved Hide resolved
src/tokio/bufread/macros/decoder.rs Outdated Show resolved Hide resolved
src/tokio/write/generic/encoder.rs Outdated Show resolved Hide resolved
src/tokio/write/macros/encoder.rs Outdated Show resolved Hide resolved
NobodyXu
NobodyXu requested changes Oct 12, 2024
View reviewed changes
src/tokio/write/macros/decoder.rs Outdated Show resolved Hide resolved
src/tokio/write/generic/decoder.rs Outdated Show resolved Hide resolved
src/tokio/bufread/macros/encoder.rs Outdated Show resolved Hide resolved
@link2xt link2xt force-pushed the link2xt/passthrough-traits branch 2 times, most recently from cc91be3 to b81bfeb Compare October 13, 2024 03:39
NobodyXu
NobodyXu requested changes Oct 13, 2024
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is calling poll_flush in poll_close required to fix the test?

src/futures/bufread/macros/decoder.rs Outdated Show resolved Hide resolved
src/futures/bufread/macros/encoder.rs Outdated Show resolved Hide resolved
@link2xt link2xt force-pushed the link2xt/passthrough-traits branch from b81bfeb to a3d5d67 Compare October 13, 2024 06:28
@NobodyXu NobodyXu added this pull request to the merge queue Oct 13, 2024
@NobodyXu
Copy link
Collaborator

Thank you!

Merged via the queue into Nullus157:main with commit 5f51d42 Oct 13, 2024
16 checks passed
This was referenced Oct 13, 2024
Closed
Merged
@link2xt link2xt mentioned this pull request Oct 15, 2024
Merged
@robjtede robjtede added the A-semver-minor non-breaking change label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
A-semver-minor non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrapping an AsyncRead + AsyncWrite stream
3 participants
@link2xt @NobodyXu @robjtede