Remove support for tokio 0.2 and 0.3 #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Nemo157
force-pushed
the
remove-old-tokio
branch
2 times, most recently
from
3e5b137 to
f3dfcab
Compare
|
Nice change! |
|
@Nemo157 Is there other concerns that block this PR get merged? |
robjtede
approved these changes
May 6, 2023
|
I think it would be worth merging a zstd update and pushing that before going to 0.4, so that there's less pressure on downstream updating. |
robjtede
reviewed
May 8, 2023
robjtede
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have checked the index using
rg -IN 'async-compression' | jq -r '"\(.name) \(.vers): \(.deps[] | select(.name == "async-compression") | .features | join(", "))"'and there are only 2 crates that have their latest version still usingtokio-02and no crates usingtokio-03.I wanted to wait for
stdto introduce some async IO traits and go directly to 1.0 when removing this support, but given how long it has been and how far away that still appears to be, I think it's time to do this now. This will simplify exposing more of the internals in order to allow some of the usecases people want (#133, #150).