Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for eslint 9 #732

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

davidtaylorhq
Copy link
Contributor

@davidtaylorhq davidtaylorhq commented Nov 8, 2024

The plugin itself already works under eslint 9. Some small tweaks were needed to get pnpm test passing under eslint 9.

Keeping this draft for now though, because the sharable configs will need updating to support ESLint flat configs.

Copy link

stackblitz bot commented Nov 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Nov 8, 2024

🦋 Changeset detected

Latest commit: 101261b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-decorator-position Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@NullVoxPopuli
Copy link
Owner

thank you!!

@davidtaylorhq
Copy link
Contributor Author

I've introduced new standard configs under a different import path, and also simplified them so they only set up this plugin. General parser configuration is now up to the consuming application.

I think that makes sense, given that this is such a specific plugin - it's almost certain any consumer will want to add it to an existing config rather than starting from scratch.

I've also dropped ESLint 6 support, because it would require some further refactoring of the tests to maintain. LMK if you prefer to keep it, and I'll figure something out.

Otherwise, I think this is ready for review.

@davidtaylorhq davidtaylorhq marked this pull request as ready for review November 11, 2024 14:32
- Adds ESLint 9 support
- Drops ESLint 6 support
- Introduces new 'flat-config' compatible configs under a new import path
- Introduces a new smoke-test for those configs
- Updates CI matrices accordingly
@NullVoxPopuli NullVoxPopuli added enhancement New feature or request breaking labels Nov 11, 2024
@NullVoxPopuli NullVoxPopuli merged commit 2cc7aa3 into NullVoxPopuli:main Nov 11, 2024
30 checks passed
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants