Skip to content

Commit

Permalink
chore(ci): add eslint to ci
Browse files Browse the repository at this point in the history
BREAKING CHANGE: drop support for eslint@5

this technically isn't a breaking change, as eslint@5 likely never
worked. But now CI is testing supported versions of eslint.
  • Loading branch information
NullVoxPopuli committed Sep 28, 2021
1 parent 84ab1f1 commit 0cbbf6e
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
13 changes: 12 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,26 @@ jobs:
- "12"
- "14"
- "16"
eslint:
- "eslint@7"
- "eslint@6"
steps:
- uses: actions/checkout@v2
- uses: volta-cli/action@v1
with:
node-version: ${{ matrix.node }}
- run: yarn install
- run: |
yarn install
yarn remove eslint
yarn add ${{ matrix.eslint }}
- name: Test with ${{ matrix.node }}
run: |
echo "Matrix Info"
echo "Intended: ${{ matrix.node }}, ${{ matrix.eslint }}"
echo "node: $(node -v)"
echo "yarn why eslint"
yarn why eslint
yarn test:coverage --runInBand
yarn update && git diff --exit-code README.md docs/
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
## ❗️Requirements

- [ESLint](https://eslint.org/) `>= 5`
- [ESLint](https://eslint.org/) `>= 6`
- [Node.js](https://nodejs.org/) `>= 10`

## 🚀 Usage
Expand Down

0 comments on commit 0cbbf6e

Please sign in to comment.