fix: incorrect value returned when last task was dropped #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f708824 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rpemberton
changed the title
rpemberton
force-pushed
the
rp/fix-incorrect-task-value
branch
from
48cba3b to
6bdcc8b
Compare
|
Looks great! thanks so much for working on this!! <3 |
rpemberton
force-pushed
the
rp/fix-incorrect-task-value
branch
from
6bdcc8b to
e4d9336
Compare
|
I just remembered this is supposed to target the v5 branch. I'll see if I can fix that. |
don't worry about it -- I'll backport |
…opped Ensure that cancelled tasks are ignored
|
Already switched to v5. Hope that's ok. |
rpemberton
force-pushed
the
rp/fix-incorrect-task-value
branch
from
e4d9336 to
ed6828c
Compare
|
of course <3 forward-porting is easier |
Update changeset
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #835