[Blocked]: do not compile away properties and methods #616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be tested with a couple consumers before merge, this could be considered a breaking change if consumers are not expecting to have to compile away private fields / methods or class fields / methods entirely. I think ember-cli-babel will handle this for them tho.
This is BLOCKED until this is resolved:
atm, babel compiles in a runtime error if the class-properties transform hasn't ran.
Error: Decorating class property failed. Please ensure that proposal-class-properties is enabled and runs after the decorators transform. emberjs/ember-cli-babel#447
Did some math in a googlesheet: https://docs.google.com/spreadsheets/d/12k6wnuvE4peVqQRMGFHCYq3fXgx5tsadlyPIolEQKnY/edit?usp=sharing