ship, increment, ship again

NullVoxPopuli · Dec 27, 2023 · 815a04b · 815a04b
1 parent 2090349
commit 815a04b
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 3 deletions.
diff --git a/packages/ember/typescript/index.js b/packages/ember/typescript/index.js
@@ -3,7 +3,7 @@ import assert from 'node:assert';
 import { dirname } from 'node:path';
 import { fileURLToPath } from 'node:url';
 
-import { ember, packageJson } from 'ember-apply';
+import { ember, packageJson, project } from 'ember-apply';
 
 import { createConfigDTS } from './src/config-directory.js';
 import {
@@ -73,6 +73,21 @@ async function appToTypeScript() {
   await adjustAppScripts();
   await setupESLint();
   await configureDependencies();
+
+  let manager = await project.getPackageManager();
+
+  console.info(`
+    ✨✨✨
+
+    🥳 Your JavaScript app is now a TypeScript app 🥳
+
+    Tasks to manually do
+    - run '${manager} install'
+    - make sure '${manager} run lint:types' succeeds
+    - commit!
+
+    ✨✨✨
+  `);
 }
 
 async function addonToTypeScript() {

diff --git a/packages/ember/typescript/src/package-json.js b/packages/ember/typescript/src/package-json.js
@@ -6,7 +6,9 @@ export async function adjustAppScripts() {
 
 import { canUseBuiltInTypes, isEmberDataPresent } from './queries.js';
 
-export async function adjustAddonScripts() {}
+export async function adjustAddonScripts() {
+  throw new Error(`Addons are not yet supported. PR's welcome!`);
+}
 
 const standardDeps = [
   '@tsconfig/ember',
@@ -29,6 +31,7 @@ export async function configureDependencies() {
     return;
   } else {
     if (await isEmberDataPresent()) {
+      throw new Error(`Ember data isn't yet supported. PR's welcome!`);
     }
   }
 }
diff --git a/packages/ember/typescript/src/types-directory.js b/packages/ember/typescript/src/types-directory.js
@@ -37,10 +37,17 @@ export async function createAppTypesDirectory() {
 
 export async function createAddonTypesDirectory() {
   if (await canUseBuiltInTypes()) {
+    await fse.writeFile(
+      'types/global.d.ts',
+      stripIndent`
+        // Declare the @ember/* packages brought in from ember-source
+        import 'ember-source/types';
+      `,
+    );
   }
 
   await fse.writeFile(
-    `unpublished-development-types/index.d.ts`,
+    `unpublished-development-types/glint.d.ts`,
     stripIndent`
       // Add any types here that you need for local development only.
       // These will *not* be published as part of your addon, so be careful that your published code does not rely on them!