Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep CompleteMultipartUpload alive #31

Closed
wants to merge 4 commits into from

Conversation

lperlaki
Copy link
Contributor

@lperlaki lperlaki commented Apr 11, 2023

changes the response body from the CompleteMultipartUpload Operation to a custom KeepAliveBody that sends a whitespace every 100 milliseconds to keep the request alive

fixes #30


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lperlaki lperlaki force-pushed the complete_multipart_keepalive branch from b766751 to 563990a Compare April 11, 2023 09:14
@Nugine Nugine mentioned this pull request Apr 11, 2023
@lperlaki lperlaki force-pushed the complete_multipart_keepalive branch from 280ab64 to 5b7329e Compare April 11, 2023 11:47
@lperlaki lperlaki force-pushed the complete_multipart_keepalive branch from 5b7329e to b5c48e2 Compare April 11, 2023 11:48
@lperlaki lperlaki changed the title experimental keep CompleteMultipartUpload alive keep CompleteMultipartUpload alive Apr 11, 2023
@lperlaki lperlaki marked this pull request as ready for review April 11, 2023 11:54
@Nugine Nugine self-requested a review April 11, 2023 12:05
@Nugine
Copy link
Owner

Nugine commented Apr 11, 2023

E2E tests failed.

https://github.com/Nugine/s3s/actions/runs/4667234570/jobs/8262777066?pr=31

  • aws-sdk-php
  • minio-py

Development Guide

https://github.com/Nugine/s3s/blob/main/CONTRIBUTING.md#run-e2e-tests

Action defintion

mint:
name: e2e (s3s-proxy, mint)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly
- run: docker pull minio/mint:edge
- run: docker pull minio/minio:latest
- run: cargo install --path crates/s3s-proxy
- run: |
export RUST_LOG=s3s_proxy=debug,s3s_aws=debug,s3s=debug,hyper=trace
./scripts/e2e-mint.sh
- run: cat target/s3s-proxy.ansi
- run: cat target/mint.log
- run: ./scripts/report-mint.py /tmp/mint/log.json

@Nugine
Copy link
Owner

Nugine commented Apr 11, 2023

It seems more difficult than I imagined since hyper doesn't support HTTP/1.1 Trailers now.

@lperlaki
Copy link
Contributor Author

oh I did not know that. thank you for investigating

@Nugine Nugine added the blocking Unactionable due to upstream issues or design problems label Apr 11, 2023
@Nugine
Copy link
Owner

Nugine commented Apr 12, 2023

@Nugine Nugine removed their request for review May 15, 2023 06:27
@Nugine Nugine closed this Jul 14, 2023
@Nugine
Copy link
Owner

Nugine commented Jul 14, 2023

Will reopen if the upstream issue is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking Unactionable due to upstream issues or design problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout with CompleteMultipartUpload
2 participants