This repository has been archived by the owner on Aug 3, 2024. It is now read-only.
Improve SubscriptionProcessor's telemetry for messages exceeding expected duration #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
joelverhagen,
agr,
xavierdecoster,
shishirx34,
ryuyu,
dtivel,
chenriksson,
cristinamanum,
skofman1,
scottbommarito and
zhhyu
dtivel
approved these changes
Nov 21, 2018
loic-sharma
changed the title
agr
approved these changes
Nov 21, 2018
This was referenced Nov 22, 2018
loic-sharma
added a commit
to NuGet/NuGet.Jobs
that referenced
this pull request
Nov 27, 2018
Today, we have to parse Application Insights logs to figure out how a message handler's duration. This makes it impossible to dashboard and monitor. This metric will let us detect messages that caused deadlettering by exceeding their expected duration. Depends on NuGet/ServerCommon#230 Part of NuGet/NuGetGallery#6624
joelverhagen
pushed a commit
to NuGet/NuGet.Jobs
that referenced
this pull request
Oct 26, 2020
Today, we have to parse Application Insights logs to figure out how a message handler's duration. This makes it impossible to dashboard and monitor. This metric will let us detect messages that caused deadlettering by exceeding their expected duration. Depends on NuGet/ServerCommon#230 Part of NuGet/NuGetGallery#6624
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, we have to parse Application Insights logs to figure out how a message handler's duration. This makes it impossible to dashboard and monitor. This metric will let us detect messages that caused deadlettering by exceeding their expected duration.
I also fixed a bunch of build warnings as part of this change.
Part of: NuGet/NuGetGallery#6624
Build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=2228537&view=logs