Abstract typosquatting #9767
Abstract typosquatting #9767
Conversation
erdembayar
force-pushed
the
dev-eryondon-abstracttyposq1
branch
from
fbeb33a to
1c4c856
Compare
erdembayar
force-pushed
the
dev-eryondon-abstracttyposq1
branch
2 times, most recently
from
a2b703f to
3c28fba
Compare
| @@ -1,213 +0,0 @@ | |||
| // Copyright (c) .NET Foundation. All rights reserved. | |||
There was a problem hiding this comment.
This one is moved to abstraction helper.
| @@ -13,33 +13,29 @@ namespace NuGetGallery | |||
| { | |||
| public class TyposquattingService : ITyposquattingService | |||
| { | |||
| private static readonly IReadOnlyList<ThresholdInfo> ThresholdsList = new List<ThresholdInfo> | |||
There was a problem hiding this comment.
This one is moved to abstraction helper.
| @@ -138,29 +134,5 @@ public bool IsUploadedPackageIdTyposquatting(string uploadedPackageId, User uplo | |||
|
|
|||
| return wasUploadBlocked; | |||
| } | |||
| private static int GetThreshold(string packageId) | |||
There was a problem hiding this comment.
This one is moved to abstraction helper.
| @@ -1,86 +0,0 @@ | |||
| // Copyright (c) .NET Foundation. All rights reserved. | |||
There was a problem hiding this comment.
This one is moved to abstraction helper.
erdembayar
force-pushed
the
dev-eryondon-abstracttyposq1
branch
2 times, most recently
from
be92ced to
9454866
Compare
tests/NuGetGallery.Core.Facts/TestUtils/TestTyposquattingServiceHelper.cs
Outdated
Show resolved
Hide resolved
| @@ -137,93 +138,6 @@ public void CheckNotTyposquattingBySameOwnersTest() | |||
| Assert.Equal(0, typosquattingCheckCollisionIds.Count); | |||
| } | |||
|
|
|||
| [Fact] | |||
There was a problem hiding this comment.
This one is moved to abstraction helper.
| } | ||
|
|
||
| [Theory] | ||
| [InlineData("Microsoft_NetFramework_v1", "Microsoft.NetFramework.v1", 0)] |
There was a problem hiding this comment.
This one is moved to abstraction helper.
erdembayar
force-pushed
the
dev-eryondon-abstracttyposq1
branch
4 times, most recently
from
c40c470 to
186a748
Compare
|
|
||
| return typosquattingService; | ||
| }) | ||
| .AsSelf() |
There was a problem hiding this comment.
Do we plan to have that type resolved as self? Wouldn't .As<ITyposquattingServiceHelper>() be enough?
There was a problem hiding this comment.
Tbh this method is new to me, I just copied from line 1570 above assuming how it's done.
There was a problem hiding this comment.
I'd guess, there is no need for it to be there as well :)
There was a problem hiding this comment.
Removed here, I think removing other instances are out of scope for this PR. If you wish I can create a tracking issue for those.
erdembayar
force-pushed
the
dev-eryondon-abstracttyposq1
branch
from
186a748 to
2f97833
Compare
Tracking issue: https://github.com/NuGet/Engineering/issues/4815
See at tracking issue for related PRs.