Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minification failures and delete unused assets #7963

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Fix minification failures and delete unused assets #7963

merged 1 commit into from
Apr 25, 2020

Conversation

joelverhagen
Copy link
Member

  • Add tests to detect minification failures in the future. Basically WebGrease uses an older view the JS and CSS syntax. I had to update to the latest WebGrase to address CSS minification failures.
  • Revert newer JavaScript syntax that breaks minification
  • Minify some unminified files
  • Delete an unused copy of jQuery UI
  • Delete unused syntax highlighter CSS

Address https://github.com/NuGet/Engineering/issues/3107

joelverhagen added a commit that referenced this pull request Apr 24, 2020
@joelverhagen
Fix minification failures and delete unused assets (#7963)
71f0fdd 
Address NuGet/Engineering#3107
joelverhagen added a commit that referenced this pull request Apr 24, 2020
@joelverhagen
Fix minification failures and delete unused assets (#7963)
3c4862e 
Address NuGet/Engineering#3107
loic-sharma
loic-sharma approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests 👍

joelverhagen added a commit that referenced this pull request Apr 24, 2020
@joelverhagen
Fix minification failures and delete unused assets (#7963)
ded2c51 
Address NuGet/Engineering#3107
joelverhagen added a commit that referenced this pull request Apr 24, 2020
@joelverhagen
Fix minification failures and delete unused assets (#7963)
086ea64 
Address NuGet/Engineering#3107
joelverhagen added a commit that referenced this pull request Apr 24, 2020
@joelverhagen
Fix minification failures and delete unused assets (#7963)
f72cf99 
Address NuGet/Engineering#3107
@joelverhagen joelverhagen merged commit 7322a06 into dev Apr 25, 2020
@agr agr mentioned this pull request May 4, 2020
Closed
14 tasks
@joelverhagen joelverhagen deleted the jver-min branch November 13, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@agr agr agr approved these changes

@cristinamanum cristinamanum Awaiting requested review from cristinamanum

@dannyjdev dannyjdev Awaiting requested review from dannyjdev

@ryuyu ryuyu Awaiting requested review from ryuyu

@shishirx34 shishirx34 Awaiting requested review from shishirx34

@skofman1 skofman1 Awaiting requested review from skofman1

@xavierdecoster xavierdecoster Awaiting requested review from xavierdecoster

@zhhyu zhhyu Awaiting requested review from zhhyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelverhagen @agr @loic-sharma