Don't fall back to email address when finding the user for ChangePassword #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heading out - feel free to process the merge if you sign off. :-) |
|
Where did we land on this? |
|
Hmm.. Not sure we ever pulled it in. I vote to leave the naming as-is and merge the change in. Can you follow through on this please, @anglicangeek? |
joelverhagen
pushed a commit
that referenced
this pull request
Jul 29, 2024
This change removes the `IProcessor`, `IValidationRequest`, `IValidationResult`, `IValidator`, and `ValidationResult` types as they will be moved to the NuGet.Jobs repository (see NuGet/NuGet.Jobs#958). These types were originally in the ServerCommon repository to allow for Orchestrator validators in private repositories. This flexibility adds serious engineering overhead, and we don't plan on adding validators in private repositories. Part of: https://github.com/NuGet/Engineering/issues/3614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.