Verify package with language, devdep & deps #2834
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR with just the VerifyPackage enhancements (instead of #2242) - just in read only mode.
The Verify Package Page now shows also:
Sample 1:
Sample 2 - with DevDependency:
Sample 3:
Problems:
The "PackageMetadata" doesn't read the MinimumClientVersion at all and a real DevelopmentDependency property is missing on the class. I could get the DevelopmentDependency Value via the key, but maybe a real property would be cleaner.
If the DevelopmentDependency property is not found the default "not specified" appears, but this would be easy to change.
I noticed that the frameworkassembly/dependency stuff has changed - I just saw the visualization of the dependencies on the details page, maybe I should adapt this kind of style, right?
What do you think?