Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify package with language, devdep & deps #2834

Merged
merged 1 commit into from
Dec 24, 2015

Conversation

robertmuehsig
Copy link
Contributor

New PR with just the VerifyPackage enhancements (instead of #2242) - just in read only mode.

The Verify Package Page now shows also:

  • Language
  • Minimum Client Version
  • Dev Dependeny
  • FrameworkAssemblies
  • Other Dependencies

Sample 1:
image

Sample 2 - with DevDependency:
image

Sample 3:
image

Problems:
The "PackageMetadata" doesn't read the MinimumClientVersion at all and a real DevelopmentDependency property is missing on the class. I could get the DevelopmentDependency Value via the key, but maybe a real property would be cleaner.
If the DevelopmentDependency property is not found the default "not specified" appears, but this would be easy to change.

I noticed that the frameworkassembly/dependency stuff has changed - I just saw the visualization of the dependencies on the details page, maybe I should adapt this kind of style, right?

What do you think?

@maartenba maartenba merged commit 2dcef8c into NuGet:dev Dec 24, 2015
maartenba added a commit that referenced this pull request Dec 24, 2015
@robertmuehsig
Copy link
Contributor Author

uh - wow. That was fast 👍
Is the "packageMetadata.MinClientVersion" still a thing? What about the missing devDependency property (like packageMetadata.DevelopmentDependency)?

@maartenba
Copy link
Contributor

Not currently on the server radar (but something we may get on the radar at one point)

Thanks for the PR! Merged with the suggested UI edits, will go live on next deploy.

@maartenba maartenba mentioned this pull request Dec 24, 2015
4 tasks
@robertmuehsig
Copy link
Contributor Author

Good to hear!
If MinClientVersion is always null then there is no need to display it - it might even confuse people if the value is set in the nuspec but not displayed correctly? Or is there a way I could help to fix this "broken" behavior?

@maartenba
Copy link
Contributor

Just pushed a fix for that on dev.

@304NotModified
Copy link
Contributor

woohoo! nice this PR! \0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants