Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1554 by adding some word breaking styles #1674

Merged
merged 2 commits into from
Oct 31, 2013
Merged

Conversation

analogrelay
Copy link
Contributor

Fixes #1554

Now it does this:
image
Not perfect, but better.

Also, fixed word breaking on the package details page:
image

@jeffhandley
Copy link
Member

Please make sure to check this in several browsers. CodePlex has had a really hard time with getting a cross-browser fix for this kind of issue.


From: Andrew Nursemailto:[email protected]
Sent: ý10/ý22/ý2013 5:38 PM
To: NuGet/NuGetGallerymailto:[email protected]
Subject: [NuGetGallery] Fix #1554 by adding some word breaking styles (#1674)

Fixes #1554#1554

Now it does this:
[image]https://f.cloud.github.com/assets/7574/1386713/47c4b4b2-3b7b-11e3-8ed5-c8ec1abbd316.png
Not perfect, but better.

Also, fixed word breaking on the package details page:
[image]https://f.cloud.github.com/assets/7574/1386715/5fd8793a-3b7b-11e3-83a3-2d5f660b0c1e.png


You can merge this Pull Request by running

git pull https://github.com/NuGet/NuGetGallery anurse/1554-cssupdates

Or view, comment on, or merge it at:

#1674

Commit Summary

File Changes

Patch Links:

@analogrelay
Copy link
Contributor Author

I believe I tested in IE and Chrome, but I will make sure to do so again just to be safe.

@analogrelay
Copy link
Contributor Author

Made a couple small tweaks and now it works well in the current version of all four major browsers:

Chrome:
image
image
image

IE:
image
image
image

Opera:
image
image
image

Firefox:
image
image
image

@TimLovellSmith
Copy link
Member

Cool! Thanks for fixing this Andrew!

analogrelay added a commit that referenced this pull request Oct 31, 2013
Fix #1554 by adding some word breaking styles
@analogrelay analogrelay merged commit 8327618 into dev Oct 31, 2013
@analogrelay analogrelay deleted the anurse/1554-cssupdates branch December 9, 2013 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants