Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1435 by cleaning up our code a bit #1673

Merged
merged 1 commit into from
Oct 31, 2013
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/NuGetGallery/DataServices/SearchAdaptor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ private static bool TryReadSearchFilter(string url, out SearchFilter searchFilte

searchFilter = new SearchFilter
{
// HACK: The way the default paging works is WCF attempts to read up to the MaxPageSize elements. If it finds as many, it'll assume there
// The way the default paging works is WCF attempts to read up to the MaxPageSize elements. If it finds as many, it'll assume there
// are more elements to be paged and generate a continuation link. Consequently we'll always ask to pull MaxPageSize elements so WCF generates the
// link for us and then allow it to do a Take on the results. The alternative to do is roll our IDataServicePagingProvider, but we run into
// issues since we need to manage state over concurrent requests. This seems like an easier solution.
Expand Down
2 changes: 1 addition & 1 deletion src/NuGetGallery/Infrastructure/Lucene/AnalysisHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public static Lucene.Net.Search.Query GetFieldQuery(Analyzer analyzer, string fi
TokenFilter filter = new CachingTokenFilter(stream);
filter.Reset();

// This attribute way of getting token properties sucks, but it's the non-obsolete one.
// This attribute way of getting token properties isn't very good, but it's the non-obsolete one.
var attr1 = filter.GetAttribute<ITermAttribute>();
Func<string> getText = () => attr1 != null ? attr1.Term : null;

Expand Down
2 changes: 1 addition & 1 deletion src/NuGetGallery/Services/PackageFileService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ private static string BuildFileName(string id, string version)
// Note: packages should be saved and retrieved in blob storage using the lower case version of their filename because
// a) package IDs can and did change case over time
// b) blob storage is case sensitive
// c) it sucks to hit the database just to look up the right case
// c) we don't want to hit the database just to look up the right case
// and remember - version can contain letters too.
return String.Format(
CultureInfo.InvariantCulture,
Expand Down
2 changes: 1 addition & 1 deletion tests/NuGetGallery.Facts/Services/PackageServiceFacts.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1059,7 +1059,7 @@ public void ReturnsTheRequestedPackageVersion()

Assert.DoesNotThrow(() => service.FindPackageByIdAndVersion("theId", "1.0.42"));

// Nothing to assert because it's too damn complicated to test the actual LINQ expression.
// Nothing to assert because it's too complicated to test the actual LINQ expression.
// What we're testing via the throw above is that it didn't load the registration and get the latest version.
}

Expand Down