Fix #1657 by allowing any request URI, but disabling static file serving... #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing outside of known directories
|
Tim reminded me that we have some static files in the Errors folder we should make sure work. |
|
This looks good. How about you also get rid of all our EnsureTrailingSlash calls. Otherwise this might be hard to test. |
| @@ -195,6 +195,7 @@ private int Replicate(string source, string destination, int batchSize, int expe | |||
| do | |||
| { | |||
| int originalKey = GetLastOriginalKey(destination); | |||
| Log.Trace("replicating records since {0}", originalKey); | |||
There was a problem hiding this comment.
are these changes unrelated?
There was a problem hiding this comment.
Yeah, not sure why they're here. I'll try to remove them, but if I can't they aren't going to cause any problems.
analogrelay
added a commit
that referenced
this pull request
Nov 4, 2013
Fix #1657 by allowing any request URI, but disabling static file serving...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... outside of known directories
Fixes #1657