-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Johtaylo 1283 d3 on ie7 #1331
Johtaylo 1283 d3 on ie7 #1331
Conversation
correction: 1291 in the list of bugs is a typo. (and to clarify this checkin does not address 1295 - that will be a separate checkin) |
Test Failures: http://build.nuget.org/viewLog.html?buildId=2655&tab=buildLog&buildTypeId=bt12&logTab=all Ctrl-F for "2013-07-16 18:53:21,999 [2556] WARN" to find the first one: [Step 1/3] 2013-07-16 18:53:21,999 [2556] WARN JetBrains.Container.Log4netDefaultLoggerInitializer - Unhandled exception in current domain: System.NullReferenceException: Object reference not set to an instance of an object. |
Also, please remember to update Huboard for these issues. |
fixed test issues |
@@ -327,5 +333,21 @@ private static string MakeReportId(string[] groupby) | |||
} | |||
return graphId; | |||
} | |||
|
|||
private bool useD3() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We almost never (in fact, I think never) use camelCased method names. Minor nit pick, but would be nice to fix.
Minor nitpick, but basically |
OK fixed that, thanks Andrew. |
fixes #1293
fixes #1291
fixes #1283
fixes #1282
Addresses accessibility by showing the HTML tables on the main statistics page. The other (per package) svg graphs are already duplicating data from the tables.