Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Johtaylo 1283 d3 on ie7 #1331

Merged
merged 3 commits into from
Jul 18, 2013
Merged

Johtaylo 1283 d3 on ie7 #1331

merged 3 commits into from
Jul 18, 2013

Conversation

johnataylor
Copy link
Member

fixes #1293
fixes #1291
fixes #1283
fixes #1282

Addresses accessibility by showing the HTML tables on the main statistics page. The other (per package) svg graphs are already duplicating data from the tables.

@johnataylor
Copy link
Member Author

correction: 1291 in the list of bugs is a typo. (and to clarify this checkin does not address 1295 - that will be a separate checkin)

@analogrelay
Copy link
Contributor

Test Failures: http://build.nuget.org/viewLog.html?buildId=2655&tab=buildLog&buildTypeId=bt12&logTab=all

Ctrl-F for "2013-07-16 18:53:21,999 [2556] WARN" to find the first one:

[Step 1/3] 2013-07-16 18:53:21,999 [2556] WARN JetBrains.Container.Log4netDefaultLoggerInitializer - Unhandled exception in current domain: System.NullReferenceException: Object reference not set to an instance of an object.
at NuGetGallery.StatisticsController.useD3() in c:\TeamCity\buildAgent\work\5d00fe9dafc32d61\Website\Controllers\StatisticsController.cs:line 341
at NuGetGallery.StatisticsController.d__1.MoveNext() in c:\TeamCity\buildAgent\work\5d00fe9dafc32d61\Website\Controllers\StatisticsController.cs:line 129
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at System.Runtime.CompilerServices.TaskAwaiter1.GetResult() at NuGetGallery.StatisticsControllerFacts.<StatisticsHomePage_ValidateFullReportStructureAndAvailability>d__29.MoveNext() in c:\TeamCity\buildAgent\work\5d00fe9dafc32d61\Facts\Controllers\StatisticsControllerFacts.cs:line 209 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<ThrowAsync>b__1(Object state) at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem() at System.Threading.ThreadPoolWorkQueue.Dispatch(), at NuGetGallery.StatisticsController.useD3() in c:\TeamCity\buildAgent\work\5d00fe9dafc32d61\Website\Controllers\StatisticsController.cs:line 341 at NuGetGallery.StatisticsController.<Index>d__1.MoveNext() in c:\TeamCity\buildAgent\work\5d00fe9dafc32d61\Website\Controllers\StatisticsController.cs:line 129 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter1.GetResult()
at NuGetGallery.StatisticsControllerFacts.<StatisticsHomePage_ValidateFullReportStructureAndAvailability>d__29.MoveNext() in c:\TeamCity\buildAgent\work\5d00fe9dafc32d61\Facts\Controllers\StatisticsControllerFacts.cs:line 209
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.b__1(Object state)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
at System.Threading.QueueUserWorkItemCallback.System.Threading.IThreadPoolWorkItem.ExecuteWorkItem()
at System.Threading.ThreadPoolWorkQueue.Dispatch(), (null)

@analogrelay
Copy link
Contributor

Also, please remember to update Huboard for these issues.

@johnataylor
Copy link
Member Author

fixed test issues

@@ -327,5 +333,21 @@ private static string MakeReportId(string[] groupby)
}
return graphId;
}

private bool useD3()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We almost never (in fact, I think never) use camelCased method names. Minor nit pick, but would be nice to fix.

@analogrelay
Copy link
Contributor

Minor nitpick, but basically :shipit:

@johnataylor
Copy link
Member Author

OK fixed that, thanks Andrew.

johnataylor added a commit that referenced this pull request Jul 18, 2013
@johnataylor johnataylor merged commit 875c365 into dev Jul 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants