Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats are broken (part 6) #7258

Closed
rianjs opened this issue Jun 11, 2019 · 2 comments
Closed

Stats are broken (part 6) #7258

rianjs opened this issue Jun 11, 2019 · 2 comments

Comments

@rianjs
Copy link

rianjs commented Jun 11, 2019 •
edited
Loading

Previous incidents:

  1. Download stats are not updating as of 2017-06-12 #4389
  2. Package download stats haven't updated for two days #4572
  3. Package stats haven't updated in 24 hours #6051
  4. Package stats haven’t updated in about two days #6764
  5. Download counts are going backwards again #7053

The latest issue is that the counts are wrong again. I began to suspect something last Thursday. Here's the breakdown:

Date Count Growth 7d mean  
2019-06-04 691,767 1,525 1,842  
2019-06-05 695,453 3,686 1,934  
2019-06-06 704,091 8,638 2,808 699,043
2019-06-07 701,557 -2,534 2,135  
2019-06-08 702,320 763 1,905  
2019-06-09 704,590 2,270 2,102  
2019-06-10 704,900 310 2,094  
2019-06-11 705,250 350 1,926  
  • That 699K value in its own column was the download count 12 hours after the 704K.
  • 8.6K downloads in a 24 hour period would be the biggest day by a wide, wide margin. So it's unlikely, unless there were some downloads being dropped on the floor, and suddenly rediscovered by a cleanup job or whatever.
  • The package is ical.net -- not that it matters: https://www.nuget.org/packages/Ical.Net/

I don't want be rude, but these issues have gone back to 2017. I find these errors with the world's least sophisticated spreadsheet. These should be trivially easy to catch with tooling. Automated monitoring and alerting should be very easy to build for this.
@joelverhagen
Copy link
Member

/cc @zhhyu who is on call.
/cc @cristinamanum who investigated this last time.

@cristinamanum cristinamanum mentioned this issue Jul 2, 2019
Closed
@joelverhagen joelverhagen mentioned this issue Jul 12, 2019
Merged
joelverhagen added a commit to NuGet/NuGet.Services.Metadata that referenced this issue Jul 12, 2019
@joelverhagen
Add DownloadSetComparer to detect download count changes (#592)
a496ecb 
While comparing, fine places where download counts decrease and emit telemetry. This is a strange case currently causing some user pain and this will give us more data.

Progress on NuGet/NuGetGallery#6458
Helps with the investigation of NuGet/NuGetGallery#7258
joelverhagen added a commit to NuGet/NuGet.Services.Metadata that referenced this issue Jul 16, 2019
@joelverhagen
Add DownloadSetComparer to detect download count changes (#592)
2b286e2 
While comparing, fine places where download counts decrease and emit telemetry.
This is a strange case currently causing some user pain and this will give us more data.
Progress on NuGet/NuGetGallery#6458
Helps with the investigation of NuGet/NuGetGallery#7258
@skofman1
Copy link
Contributor

Closing this one since we are tracking fixes on #7053

joelverhagen added a commit to NuGet/NuGet.Jobs that referenced this issue Oct 26, 2020
@joelverhagen
Add DownloadSetComparer to detect download count changes (#592)
f2e969a 
While comparing, fine places where download counts decrease and emit telemetry.
This is a strange case currently causing some user pain and this will give us more data.
Progress on NuGet/NuGetGallery#6458
Helps with the investigation of NuGet/NuGetGallery#7258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joelverhagen @rianjs @skofman1