Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package validation for the MinClientVersion attribute #1745

Closed
jeffhandley opened this issue Nov 25, 2013 · 1 comment · Fixed by #1743
Closed

Add package validation for the MinClientVersion attribute #1745

jeffhandley opened this issue Nov 25, 2013 · 1 comment · Fixed by #1743
Assignees

Comments

@jeffhandley
Copy link
Member

There are quite a few packages in the gallery that have the MinClientVersion property set to the package's version number instead of the NuGet client version.

I suspect this is largely due to bad UI in NuGet Package Explorer where it doesn't state what the Minimum Client Version is for. I've reported that to @dotnetjunky too.

We should add some validation to the gallery around this value though. The best solution would be to find the highest version of the NuGet.Core package in the gallery, then allow the MinClientVersion to be anything up to that version. Anything higher than NuGet.Core's highest version would be an error. Alternatively, we could use the NuGet.Core version the Gallery is built against. Last resort, it's hard-coded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants