This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
[Package Renames 2] Support popularity transfers comparisons #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
joelverhagen,
agr,
xavierdecoster,
shishirx34,
cristinamanum,
skofman1,
dannyjdev,
zhhyu and
dc7497-1576912
loic-sharma
commented
Apr 13, 2020
| string keyName, | ||
| string valuesName, | ||
| StringComparer valuesComparer) | ||
| { |
There was a problem hiding this comment.
This logic is almost the same as the previous OwnerSetComparer.Compare method.
loic-sharma
changed the title
ryuyu
approved these changes
Apr 14, 2020
joelverhagen
approved these changes
Apr 14, 2020
loic-sharma
force-pushed
the
loshar-popxfer-compare
branch
from
43ff62c to
ee29f41
Compare
loic-sharma
added a commit
that referenced
this pull request
Apr 14, 2020
The `db2azuresearch` and `auxiliary2azuresearch` jobs needs to get the latest popularity transfers from the database. ⚠ This change is not unit testable as it interacts with a database. This will be covered by end-to-end tests and monitoring. Previous changes: #765 and #766. Part of NuGet/NuGetGallery#7898
joelverhagen
pushed a commit
to NuGet/NuGet.Jobs
that referenced
this pull request
Oct 26, 2020
The `db2azuresearch` and `auxiliary2azuresearch` jobs needs to get the latest popularity transfers from the database. ⚠ This change is not unit testable as it interacts with a database. This will be covered by end-to-end tests and monitoring. Previous changes: NuGet/NuGet.Services.Metadata#765 and NuGet/NuGet.Services.Metadata#766. Part of NuGet/NuGetGallery#7898
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
auxiliary2azuresearchjob needs to know which popularity transfers have changed to properly update the search index.Previous change: #765
Part of NuGet/NuGetGallery#7898