This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
Remove file logging from RegistrationComparer now that AI logging is set up #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
requested review from
agr,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
cristinamanum,
skofman1,
dannyjdev and
zhhyu
joelverhagen
added a commit
that referenced
this pull request
Jan 23, 2020
…up (#733) Make the comparison container (just a cursor) public for easy monitoring Related to NuGet/NuGetGallery#7741
joelverhagen
force-pushed
the
jver-c2r-cmpp
branch
from
58e0d11 to
fe3c0ab
Compare
loic-sharma
reviewed
Jan 23, 2020
| @@ -159,7 +159,7 @@ public class HiveComparer | |||
| } | |||
| catch (InvalidOperationException ex) | |||
| { | |||
| ResultWriter.WriteWarning(ex.Message); | |||
| _logger.LogWarning(ex.Message); | |||
There was a problem hiding this comment.
Should we log the full warning given that we're no longer constrained by a file?
loic-sharma
approved these changes
Jan 23, 2020
joelverhagen
added a commit
that referenced
this pull request
Jan 23, 2020
…up (#733) Make the comparison container (just a cursor) public for easy monitoring Related to NuGet/NuGetGallery#7741
joelverhagen
force-pushed
the
jver-c2r-cmpp
branch
from
4a347ce to
e969195
Compare
…up (#733) Make the comparison container (just a cursor) public for easy monitoring Related to NuGet/NuGetGallery#7741
joelverhagen
force-pushed
the
jver-c2r-cmpp
branch
from
e969195 to
d81908c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the comparison container (just a cursor) public for easy monitoring
Related to NuGet/NuGetGallery#7741