This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
[Azure Search] Improve tokenization of initialisms #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
commented
Aug 14, 2019
| @@ -12,6 +12,6 @@ public static class PackageIdCustomTokenizer | |||
|
|
|||
| public static readonly PatternTokenizer Instance = new PatternTokenizer( | |||
| Name, | |||
| @"[.\-_,;:'*#!~+()\[\]{}\s]"); | |||
| @"((?<=[A-Z])(?=[A-Z][a-z]))|([.\-_,;:'*#!~+()\[\]{}\s])"); | |||
There was a problem hiding this comment.
This splits on:
- Whitespace
- The characters
.,\,-,_,,,;,:,',*,#,!,~,+,(,),[,],{,} - After the first character on patterns like
ABc. For example,FOOBarbecomesFOOandBar
shishirx34
reviewed
Aug 14, 2019
| { "FOOBar", new[] { "foo", "bar" } }, | ||
| { "FooBAR", new[] { "foobar", "foo", "bar" } }, | ||
| { "FOOBarBuzz", new[] { "foo", "barbuzz", "bar", "buzz" } }, | ||
| { "FooBARBuzz", new[] { "foobar", "foo", "bar", "buzz" } }, |
There was a problem hiding this comment.
may be also include set of charachters including split tokens spaces and casings, together? like the highlighted one FOOBar.Baz Qux
There was a problem hiding this comment.
This is covered by SplitsTokensOnSpecialCharactersAndLowercases.
For more context: each data set in TokenizedData tests a single tokenization behavior. This helps us dedupe test data across many different fields in the index, each of which may have different tokenization behaviors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses NuGet/NuGetGallery#6964
Binary build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=2948640
Config build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=2936947
Release: https://devdiv.visualstudio.com/DevDiv/_releaseProgress?_a=release-pipeline-progress&releaseId=419179