This repository has been archived by the owner on Mar 16, 2021. It is now read-only.
V3 Monitoring - Improve logging when queue message processing fails #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
requested review from
joelverhagen,
agr,
xavierdecoster,
shishirx34,
nugetlurker,
ryuyu,
dtivel,
chenriksson,
cristinamanum,
skofman1 and
zhhyu
loic-sharma
approved these changes
Nov 16, 2018
dtivel
approved these changes
Nov 16, 2018
| @@ -7,6 +7,8 @@ namespace NuGet.Services.Metadata.Catalog.Monitoring | |||
| { | |||
| public static class LogEvents | |||
| { | |||
| public static EventId QueueMessageFatalFailure = new EventId(905, "Failed to process queue message"); | |||
There was a problem hiding this comment.
Order this line below by event ID? Then it's easier to see what the next unused ID is.
loic-sharma
approved these changes
Nov 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added this when trying to debug why NuGet/NuGetGallery#6584 failed to deploy
If a validation fails to run, and its status fails to be saved, we don't properly log the exceptions. This change improves the logging so that when the job fails to process a queue message, we log everything to AI.