This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
[GH Idx] Stop uploading empty blob when job crashes #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogah
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
cristinamanum,
skofman1,
dannyjdev,
scottbommarito and
zhhyu
loic-sharma
approved these changes
Jul 30, 2019
joelverhagen
pushed a commit
that referenced
this pull request
Jul 31, 2020
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
* [GH Idx] Stop uploading empty blob when job crashes * [GH Idx] Add logging and tests for empty blob
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the GitHubIndexer job of uploading empty blobs to Azure Blob Storage. This case may happen when there is an exception that happens for all the repositories (like if a DLL is missing...)