This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Reverting the no-cleanup for validation container #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agr
requested review from
joelverhagen,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
cristinamanum,
skofman1,
dannyjdev,
scottbommarito and
zhhyu
joelverhagen
approved these changes
Aug 1, 2019
joelverhagen
added a commit
that referenced
this pull request
Jul 31, 2020
Add supporting documents for the Azure Search indexes and auxiliary data files Address NuGet/NuGetGallery#8006
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
* Revert "More granular method call verification." This reverts commit 49040a2. * Revert "Reverting some of the previous reverts" This reverts commit 0d16837. * Revert "indentation fix." This reverts commit a9c7431. * Revert "Put back some checks with `Times.Never`." This reverts commit db4447b. * Revert "Test updates" This reverts commit f0f52c4. * Revert "Added configuration item to specify SAS token expiration explicitly. Removed validation container cleanup on validation set success." This reverts commit 95bbcb3.
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
Add supporting documents for the Azure Search indexes and auxiliary data files Address NuGet/NuGetGallery#8006
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/NuGet/Engineering/issues/2549
Reverts #768