This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
[Availability] Update StatusAggregator to support new AI availability test alerts #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 22, 2019 14:08
scottbommarito
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
nugetlurker,
ryuyu,
cristinamanum,
skofman1,
dannyjdev,
zhhyu and
mogah
scottbommarito
commented
Jul 23, 2019
| @@ -77,7 +77,11 @@ public IComponent Export() | |||
|
|
|||
| if (currentComponent == null) | |||
| { | |||
| throw new InvalidOperationException($"Couldn't find component with path {activeEntity.AffectedComponentPath} corresponding to active entities."); | |||
| _logger.LogWarning( | |||
There was a problem hiding this comment.
In the past, all component paths were specified by the job, and if a component path was specified that did not exist, the process would crash.
Because I'm adding an alert that specifies its own component path, I felt it was best to remove this protection. The StatusAggregator job would be essentially permanently stuck if it encountered a malformed AI alert. This way, the process will gracefully ignore any non-existent component paths.
src/StatusAggregator/Parse/AIAvailabilityIncidentRegexParsingHandler.cs
Outdated
Show resolved
Hide resolved
tests/StatusAggregator.Tests/Parse/AIAvailabilityIncidentRegexParsingHandlerTests.cs
Show resolved
Hide resolved
loic-sharma
approved these changes
Jul 26, 2019
agr
approved these changes
Jul 29, 2019
joelverhagen
approved these changes
Jul 29, 2019
joelverhagen
pushed a commit
that referenced
this pull request
Jul 31, 2020
[ReleasePrep][2020.05.05] RI of dev into master
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
[ReleasePrep][2020.05.05] RI of dev into master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/nuget/engineering/issues/2581