This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Add retries to queries run by ImportAzureCdnStatistics #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
commented
Jun 3, 2019
|
|
||
| transaction.Rollback(); |
There was a problem hiding this comment.
The transaction will be automatically rolled back when an exception is thrown at await bulkCopy.WriteToServerAsync(downloadFactsDataTable);...no need for this call.
scottbommarito
changed the title
loic-sharma
reviewed
Jun 3, 2019
loic-sharma
reviewed
Jun 3, 2019
loic-sharma
reviewed
Jun 3, 2019
loic-sharma
reviewed
Jun 3, 2019
loic-sharma
approved these changes
Jun 3, 2019
joelverhagen
reviewed
Jun 3, 2019
joelverhagen
approved these changes
Jun 3, 2019
xavierdecoster
approved these changes
Jun 4, 2019
|
Thanks for the reviews everyone! I will deploy this to DEV and make sure everything is okay and then merge. |
joelverhagen
added a commit
that referenced
this pull request
Jul 31, 2020
Activate assembly modules and add more base configuration types to DI Consider 4XX as successfully for telemetry purposes Add KnownOperation for the V3 search endpoint Progress on NuGet/Engineering#3020
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
Activate assembly modules and add more base configuration types to DI Consider 4XX as successfully for telemetry purposes Add KnownOperation for the V3 search endpoint Progress on NuGet/Engineering#3020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a lot of deadlettered stats blobs due to retriable SQL exceptions while I was on-call last week.
Specifically, I saw a lot of
I looked at the code and saw that we had no retry logic around it at all. I looked at our other SQL calls in
NuGet.Jobsand noticed that we typically use DapperExtensions to retry, but due to the nature of the SQL queries we are running here (bulk SQL copy and a structured parameter) it was not possible to use Dapper as well so I did some refactoring to allow us to share the retry logic between Dapper and non-Dapper queries.