This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Mark validation sets as completed and no-op based off this #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
requested review from
agr,
loic-sharma,
xavierdecoster,
ryuyu,
cristinamanum,
skofman1,
dannyjdev,
scottbommarito,
zhhyu and
mogah
joelverhagen
commented
May 28, 2019
joelverhagen
commented
May 28, 2019
loic-sharma
reviewed
May 29, 2019
src/NuGet.Services.Validation.Orchestrator/PackageValidationMessageHandler.cs
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
May 29, 2019
src/NuGet.Services.Validation.Orchestrator/ValidationOutcomeProcessor.cs
Outdated
Show resolved
Hide resolved
loic-sharma
approved these changes
May 29, 2019
src/NuGet.Services.Validation.Orchestrator/ValidationOutcomeProcessor.cs
Outdated
Show resolved
Hide resolved
cristinamanum
approved these changes
May 29, 2019
joelverhagen
force-pushed
the
jver-completedpvc
branch
from
00556e3 to
9783786
Compare
joelverhagen
added a commit
that referenced
this pull request
May 30, 2019
joelverhagen
force-pushed
the
jver-completedpvc
branch
from
46c3a50 to
d866e2d
Compare
joelverhagen
added a commit
that referenced
this pull request
May 30, 2019
agr
reviewed
May 30, 2019
src/NuGet.Services.Validation.Orchestrator/ValidationOutcomeProcessor.cs
Outdated
Show resolved
Hide resolved
agr
reviewed
May 30, 2019
src/NuGet.Services.Validation.Orchestrator/PackageValidationMessageHandler.cs
Show resolved
Hide resolved
agr
approved these changes
May 30, 2019
|
Related to NuGet/NuGetGallery#7223. |
joelverhagen
force-pushed
the
jver-completedpvc
branch
from
278a0e0 to
f70192f
Compare
joelverhagen
added a commit
that referenced
this pull request
Jun 3, 2019
joelverhagen
force-pushed
the
jver-completedpvc
branch
from
f70192f to
7c714a0
Compare
joelverhagen
added a commit
that referenced
this pull request
Jul 31, 2020
Merge branch 'dev' to master
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
Merge branch 'dev' to master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on NuGet/ServerCommon#296
Progress on NuGet/NuGetGallery#7185
An important change in behavior here is that we mark the validation set as completed before sending the emails. In the happy path this means only one email will be send since all but one thread will successfully mark the validation set as completed. However if the enqueue to send the email message fails, then the email will never be sent. This already happens because the message sending is gated on the package being in the "Validating" or "Failed Validation" state, which will only happen once anyway.