Skip to content
This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
/ NuGet.Jobs Public archive

SMTP cleanup #728

Merged
merged 2 commits into from
Mar 19, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ cd bin

title #{Jobs.gallery.credentialexpiration.Title}

REM SmtpUri is expected to be of the format: smtps://username:password@host:port. Note that if username contains an "@", you need to URI encode it!

start /w gallery.credentialexpiration.exe -Configuration "#{Jobs.gallery.credentialexpiration.Configuration}" -InstrumentationKey "#{Jobs.gallery.credentialexpiration.InstrumentationKey}" -verbose true -Interval #{Jobs.gallery.credentialexpiration.Interval}

echo "Finished #{Jobs.gallery.credentialexpiration.Title}"
Expand Down
1 change: 0 additions & 1 deletion src/Gallery.CredentialExpiration/Settings/int.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"GalleryAccountUrl": "https://int.nugettest.org/account/ApiKeys",
"GalleryBrand": "NuGet Gallery",
"MailFrom": "[email protected]",
"SmtpUri": "#{Jobs.gallery.credentialexpiration.SmtpUri}",
"WarnDaysBeforeExpiration": 7,
"WhatIf": true
},
Expand Down
1 change: 0 additions & 1 deletion src/Gallery.CredentialExpiration/Settings/prod.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"GalleryAccountUrl": "https://www.nuget.org/account/ApiKeys",
"GalleryBrand": "NuGet Gallery",
"MailFrom": "[email protected]",
"SmtpUri": "#{Jobs.gallery.credentialexpiration.SmtpUri}",
"WarnDaysBeforeExpiration": 7,
"WhatIf": false
},
Expand Down
1 change: 0 additions & 1 deletion src/NuGet.Jobs.Common/Configuration/JobArgumentNames.cs
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ public static class JobArgumentNames

// Arguments specific to e-mail
public const string MailFrom = "MailFrom";
public const string SmtpUri = "SmtpUri";

// Arguments specific to StatusAggregator
public const string StatusStorageAccount = "StatusStorageAccount";
Expand Down
1 change: 0 additions & 1 deletion src/NuGet.Jobs.Common/NuGet.Jobs.Common.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
<Compile Include="JsonConfigurationJob.cs" />
<Compile Include="SecretReader\ISecretReaderFactory.cs" />
<Compile Include="SecretReader\SecretReaderFactory.cs" />
<Compile Include="SmtpUri.cs" />
<Compile Include="Configuration\JobConfigurationManager.cs" />
<Compile Include="Extensions\DapperExtensions.cs" />
<Compile Include="JobBase.cs" />
Expand Down
45 changes: 0 additions & 45 deletions src/NuGet.Jobs.Common/SmtpUri.cs

This file was deleted.

3 changes: 0 additions & 3 deletions src/NuGet.Services.Validation.Orchestrator/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,6 @@
"TopicPath": "",
"SubscriptionName": ""
},
"Smtp": {
"SmtpUri": ""
},
"Email": {
"GalleryOwner": "NuGet Gallery <[email protected]>",
"GalleryNoReplyAddress": "NuGet Gallery <[email protected]>",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,6 @@
"TopicPath": "symbol-orchestrator",
"SubscriptionName": "orchestrator"
},
"Smtp": {
"SmtpUri": ""
},
"Email": {
"GalleryOwner": "NuGet Gallery <[email protected]>",
"GalleryNoReplyAddress": "NuGet Gallery <[email protected]>",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@ internal static class JobArgumentNames
// avoids value duplication, avoids annoying namespace conflicts in this job
public const string InstrumentationKey = Jobs.JobArgumentNames.InstrumentationKey;
public const string SourceDatabase = Jobs.JobArgumentNames.SourceDatabase;
public const string SmtpUri = Jobs.JobArgumentNames.SmtpUri;
}
}