This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
ChinaStatsCollector should properly reformat scstatus of log lines #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
nugetlurker,
ryuyu,
chenriksson,
cristinamanum,
skofman1 and
zhhyu
loic-sharma
approved these changes
Jan 31, 2019
|
I would like to deploy this to DEV and verify the behavior before I merge. Thank you for the approvals. |
cristinamanum
approved these changes
Feb 1, 2019
|
Verified on dev |
joelverhagen
added a commit
that referenced
this pull request
Jul 31, 2020
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/NuGet/Engineering/issues/2041
In
CollectAzureChinaCDNLogs, CDN logs from China go through a "conversion" layer (ChinaStatsCollector) that converts them from China's format to Global's format so that they can be parsed by code shared withCollectAzureCDNLogs(CdnLogEntryParser).This conversion was being done improperly, so that the status code field (referred to as "scstatus") was not being parsed properly by
CdnLogEntryParser, leading to unsuccessful downloads (400, 404, etc) not being properly removed.Unfortunately, there does not appear to be enough information in the response to properly convert the China log lines, so I've introduced a dummy cache status string to allow it to be parsed. I've also updated the
CdnLogEntryParsercode so that it properly processes the logs we have already improperly converted so that we can reprocess those logs.