This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Orchestrator extracts license file to flatcontainer #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GetGallery.Core instead.
agr
requested review from
joelverhagen,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
chenriksson,
cristinamanum,
skofman1,
scottbommarito and
zhhyu
loic-sharma
reviewed
Nov 29, 2018
loic-sharma
reviewed
Nov 29, 2018
src/NuGet.Services.Validation.Orchestrator/PackageStatusProcessor.cs
Outdated
Show resolved
Hide resolved
|
Can we avoid downloading the package? This will have a significant negative impact on perf. |
loic-sharma
reviewed
Dec 4, 2018
loic-sharma
approved these changes
Dec 4, 2018
joelverhagen
approved these changes
Dec 5, 2018
zhhyu
added a commit
that referenced
this pull request
Dec 11, 2018
Orchestrator extracts license file to flatcontainer (#687)
joelverhagen
added a commit
that referenced
this pull request
Jul 31, 2020
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
* Added PackageStatusProcessor for package-specific code. * Added optional OnBeforeUpdateDatabaseToMakePackageAvailable to EntityStatusProcessor. * Added telemetry for license file operations. * ServerCommon version upgrade.
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
Orchestrator extracts license file to flatcontainer (#687)
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on NuGet/NuGetGallery#6533.
On successful validation, license file (if exists) is extracted from the package and saved to flat container. Extraction and saving code taken from NuGetGallery.Core (see NuGet/NuGetGallery#6674).
EntityStatusProcessor<T>was moved to proper file, made abstract and extended with protected methodsOnBeforeUpdateDatabaseToMakePackageAvailableandOnCleanupAfterDatabaseUpdateFailure.PackageStatusProcessorwas added descending fromEntityStatusProcessor<Package>overriding new methods.