This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
StatusAggregator should treat V2 Restore and Search as Active-Active components #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 29, 2018 15:54
scottbommarito
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
nugetlurker,
ryuyu,
chenriksson,
cristinamanum,
skofman1 and
zhhyu
dtivel
approved these changes
Nov 16, 2018
chenriksson
approved these changes
Nov 16, 2018
joelverhagen
pushed a commit
that referenced
this pull request
Jul 31, 2020
* Deleting icons on failure. * IIconProcessor *Async
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
* Deleting icons on failure. * IIconProcessor *Async
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/NuGet/Engineering/issues/1908
PrimarySecondaryComponentwas renamed toActivePassiveComponentActiveActiveComponentActiveActiveComponentsMessageContentBuilderTests.BuildsContentsSuccessfully_Datano longer redundant--we had everything declared twice, once withComponentStatus.Degradedand once withComponentStatus.Down, so I addedWrapDataWithComponentStatusto handle enumerating theComponentStatuss.