This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Add cache control on blobs in public containers #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shishirx34
requested review from
joelverhagen,
agr,
loic-sharma,
chenriksson,
cristinamanum and
scottbommarito
joelverhagen
reviewed
Nov 9, 2018
src/NuGet.Services.Validation.Orchestrator/ValidationPackageFileService.cs
Outdated
Show resolved
Hide resolved
joelverhagen
reviewed
Nov 9, 2018
| || !string.Equals(blobProperties.CacheControl, CoreConstants.DefaultCacheControl, StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| blobProperties.CacheControl = CoreConstants.DefaultCacheControl; | ||
| return await Task.FromResult(true); |
There was a problem hiding this comment.
The contract expects the delegate to return a task, it can be run synchronously but I don't like to have intellisense warnings.
joelverhagen
suggested changes
Nov 9, 2018
loic-sharma
approved these changes
Nov 9, 2018
cristinamanum
approved these changes
Nov 9, 2018
joelverhagen
approved these changes
Nov 9, 2018
joelverhagen
pushed a commit
that referenced
this pull request
Sep 27, 2019
Updates the legacy search functional tests to always use the configured URL. This also requires that the configured URL supports HTTPS. This change won't take effect until this is merged into the master branch. Depends on [NuGetDeployment#1137](https://nuget.visualstudio.com/NuGetMicrosoft/_git/NuGetDeployment/pullrequest/1137?_a=overview) Part of [Engineering#2686](https://github.com/nuget/engineering/issues/2686)
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
Updates the legacy search functional tests to always use the configured URL. This also requires that the configured URL supports HTTPS. This change won't take effect until this is merged into the master branch. Depends on [NuGetDeployment#1137](https://nuget.visualstudio.com/NuGetMicrosoft/_git/NuGetDeployment/pullrequest/1137?_a=overview) Part of [Engineering#2686](https://github.com/nuget/engineering/issues/2686)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NuGet/NuGetGallery#6321