This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Only test connection on first iteration #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenriksson
requested review from
joelverhagen,
cristinamanum,
loic-sharma,
agr and
shishirx34
| where TDbConfiguration : IDbConfiguration | ||
| { | ||
| var dbConfiguration = serviceProvider.GetRequiredService<IOptionsSnapshot<TDbConfiguration>>(); | ||
| if (!string.IsNullOrEmpty(dbConfiguration.Value?.ConnectionString)) | ||
| { | ||
| RegisterDatabase<TDbConfiguration>(serviceProvider); | ||
| RegisterDatabase<TDbConfiguration>(serviceProvider, testConnection); |
There was a problem hiding this comment.
Is there any way to log in AI if the test connection was invoked ?
There was a problem hiding this comment.
Test connection results are logged to AI
cristinamanum
approved these changes
Oct 30, 2018
chenriksson
force-pushed
the
chenriks-testconnection
branch
from
036ffc1 to
20785fa
Compare
joelverhagen
approved these changes
Oct 30, 2018
agr
approved these changes
Oct 31, 2018
joelverhagen
added a commit
that referenced
this pull request
Sep 27, 2019
This is necessary for hijack to work properly. Old search defaulted it to true. Address NuGet/NuGetGallery#7360
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
This is necessary for hijack to work properly. Old search defaulted it to true. Address NuGet/NuGetGallery#7360
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking: https://github.com/NuGet/Engineering/issues/1618
Investigation: TestConnection login (SQL or AAD auth) seems to fail after a few iterations, seemingly only for validation DB. Intention here is to only test the connection once, then I'll see whether there are other connectivity issues. Testing on DEV from feature branch.
Logs show "Error Number:18456,State:1,Class:14" (login failure, error information not available due to permissions). I've checked sys.event_log connectivity failures, but don't see more specifics. The validation connection string seems to work fine if we test w/ ServerCommon tool from command line.