This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Enable msbuild /t:pack on library packages #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
requested review from
agr,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
chenriksson,
cristinamanum,
skofman1,
scottbommarito and
zhhyu
joelverhagen
commented
Oct 24, 2018
| @@ -15,6 +15,10 @@ | |||
| <DefineConstants>TRACE</DefineConstants> | |||
| <TargetFrameworkProfile /> | |||
| </PropertyGroup> | |||
| <PropertyGroup> | |||
| <Authors>.NET Foundation</Authors> | |||
There was a problem hiding this comment.
I chose the minimal set of metadata to get pack working. These are internal-ish packages so I didn't want to think too much.
|
This work is similar to NuGet/NuGetGallery#6348. |
chenriksson
approved these changes
Oct 24, 2018
joelverhagen
force-pushed
the
jver-deps
branch
from
7d6bca5 to
2936750
Compare
|
@joelverhagen Opened NuGet/NuGetGallery#6592 to track the cleanup I mentioned |
joelverhagen
added a commit
that referenced
this pull request
Sep 27, 2019
The goal is to leave the existing download.v1.json data structure Downloads as-is to ensure existing search is unaffected. Instead of changing Downloads, an API is added to read this file into the more convenient DownloadData class which is flexible enough for comparison and maintaining original case of IDs. Progress on NuGet/NuGetGallery#6458
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
The goal is to leave the existing download.v1.json data structure Downloads as-is to ensure existing search is unaffected. Instead of changing Downloads, an API is added to read this file into the more convenient DownloadData class which is flexible enough for comparison and maintaining original case of IDs. Progress on NuGet/NuGetGallery#6458
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on https://github.com/NuGet/Engineering/issues/1673.
Currently, latest versions of NuGet.Jobs.Common, Validation.Symbols.Core, and Validation.ScanAndSign.Core packages have no dependencies.