This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Configure MicroBuild to sign NuGet.Jobs #590
Merged
Merged
Changes from 9 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f261001
add initial signing targets
a7fbbfd
remove excess space
8796d55
remove excess sign.scripts.targets
97e95ab
add microbuild.core packagereference
b43562d
packagehash does not need signing
e9abf3a
refresh client dimension doesn't need signing, fix nuspec
3fd1f29
add third party binaries and missing script targets
cc1acb9
remove vcs, add microbuild.core to projects missing it
e93b91a
excess whitespace
2a43db8
remove dummy files
709795a
run e2e tests orchestrator
786dad7
processsignature E2E tests script
cf02390
validate certificate E2E
1ffc42d
revalidatecertificateE2Etests
2f97d94
remove microbuild from nuspec and update test
bafcbf4
update buildbranch to specific commit
eb8b6ff
revert solution version changes
94eea91
signpath in sign.targets
995a55a
test using new sb-micro sign.scripts.targets
4c36174
bump servercommon
ccb1991
parallelize building
700e66b
Revert "parallelize building"
4b639e0
Revert "Revert "parallelize building""
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
|
||
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
<ItemGroup> | ||
<SignFilesDependsOn Include="EnumerateThirdPartyBinariesToSign" /> | ||
</ItemGroup> | ||
<Target Name="EnumerateThirdPartyBinariesToSign" AfterTargets="AfterBuild" Condition="'$(SignType)' != 'none'"> | ||
<ItemGroup> | ||
<ThirdPartyBinaries Include="AnglicanGeek.MarkdownMailer.dll" /> | ||
<ThirdPartyBinaries Include="Antlr3.Runtime.dll" /> | ||
<ThirdPartyBinaries Include="Autofac.dll" /> | ||
<ThirdPartyBinaries Include="Autofac.Extensions.DependencyInjection.dll" /> | ||
<ThirdPartyBinaries Include="Dapper.StrongName.dll" /> | ||
<ThirdPartyBinaries Include="Elmah.dll" /> | ||
<ThirdPartyBinaries Include="ICSharpCode.SharpZipLib.dll" /> | ||
<ThirdPartyBinaries Include="MarkdownSharp.dll" /> | ||
<ThirdPartyBinaries Include="Newtonsoft.Json.dll" /> | ||
<ThirdPartyBinaries Include="Newtonsoft.Json.Schema.dll" /> | ||
<ThirdPartyBinaries Include="Owin.dll" /> | ||
<ThirdPartyBinaries Include="Serilog.dll" /> | ||
<ThirdPartyBinaries Include="Serilog.Enrichers.Environment.dll" /> | ||
<ThirdPartyBinaries Include="Serilog.Enrichers.Process.dll" /> | ||
<ThirdPartyBinaries Include="Serilog.Extensions.Logging.dll" /> | ||
<ThirdPartyBinaries Include="Serilog.Sinks.ApplicationInsights.dll" /> | ||
<ThirdPartyBinaries Include="Serilog.Sinks.ColoredConsole.dll" /> | ||
<ThirdPartyBinaries Include="SerilogTraceListener.dll" /> | ||
<ThirdPartyBinaries Include="UAParser.dll" /> | ||
</ItemGroup> | ||
<ItemGroup> | ||
<FilesToSign Include="$(OutDir)%(ThirdPartyBinaries.Identity)" Condition="Exists('$(OutDir)%(ThirdPartyBinaries.Identity)')"> | ||
<Authenticode>3PartySHA2</Authenticode> | ||
</FilesToSign> | ||
</ItemGroup> | ||
<Message Text="Files to sign:%0A@(FilesToSign, '%0A')" Importance="High" /> | ||
</Target> | ||
</Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,9 +71,27 @@ | |
<PackageReference Include="WindowsAzure.Storage"> | ||
<Version>7.1.2</Version> | ||
</PackageReference> | ||
<PackageReference Include="MicroBuild.Core"> | ||
<Version>0.3.0</Version> | ||
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets> | ||
<PrivateAssets>all</PrivateAssets> | ||
</PackageReference> | ||
</ItemGroup> | ||
<ItemGroup> | ||
<Content Include="tools\azcopy\ReadMe.txt" /> | ||
</ItemGroup> | ||
<Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" /> | ||
<PropertyGroup> | ||
<SignPath>..\..\build</SignPath> | ||
<SignPath Condition="'$(BUILD_SOURCESDIRECTORY)' != ''">$(BUILD_SOURCESDIRECTORY)\build</SignPath> | ||
<SignPath Condition="'$(NuGetBuildPath)' != ''">$(NuGetBuildPath)</SignPath> | ||
<SignType Condition="'$(SignType)' == ''">none</SignType> | ||
</PropertyGroup> | ||
<Import Project="..\..\build\sign.targets" Condition="Exists('..\..\build\sign.targets')" /> | ||
<Import Project="$(SignPath)\sign.microbuild.targets" Condition="Exists('$(SignPath)\sign.microbuild.targets')" /> | ||
<ItemGroup> | ||
<PowerShellScriptsToSign Include="InstallAzCopy.ps1"/> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
</ItemGroup> | ||
<Import Project="$(SignPath)\sign.scripts.targets" Condition="Exists('$(SignPath)\sign.scripts.targets')" /> | ||
<Import Project="..\..\sign.thirdparty.targets" /> | ||
</Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# This file is a placeholder--it does nothing. | ||
# "sign.scripts.targets", which is imported by the project from ServerCommon, requires that "nssm.exe", "Functions.ps1", "PreDeploy.ps1", and "PostDeploy.ps1" all exist. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's find a way to make this place-holder file unnecessary. Perhaps a no-op powershell or an ItemGroup |
||
# Therefore, this file must exist for the build to succeed. | ||
# This file isn't packed into the .nupkg built because the .nuspec doesn't include it. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
This file is a placeholder--it does nothing. | ||
"sign.scripts.targets", which is imported by the project from ServerCommon, requires that "nssm.exe", "Functions.ps1", "PreDeploy.ps1", and "PostDeploy.ps1" all exist. | ||
Therefore, this file must exist for the build to succeed. | ||
This file isn't packed into the .nupkg built because the .nuspec doesn't include it. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if I am using dev15 😓 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't aware of exactly what this did...will revert.