This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Update few Orchestrator APIs to include ValidatingType EF queries. #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld return packages and symbols if they have the same key.
cristinamanum
requested review from
loic-sharma,
agr,
chenriksson,
skofman1,
joelverhagen,
scottbommarito,
ryuyu,
shishirx34,
zhhyu and
zivkan
shishirx34
reviewed
Sep 7, 2018
| /// <param name="packageKey">The package key for the validation request.</param> | ||
| /// <param name="validationId">The validation id for the validation request.</param> | ||
| /// <returns>Whether the <see cref="TValidator"/> has already validated this request's package in a different validation request.</returns> | ||
| Task<bool> IsRevalidationRequestAsync(int packageKey, Guid validationId); |
There was a problem hiding this comment.
It is not used.
shishirx34
approved these changes
Sep 7, 2018
chenriksson
approved these changes
Sep 7, 2018
joelverhagen
pushed a commit
that referenced
this pull request
Sep 27, 2019
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
…uld return packages and symbols if they have the same key. (#551)
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackageValidation and ValidatorStatuses tables contain data for packages and symbolpackages.
A symbolpacakge and a package could have the same key.
In this change few APIs are updated to use validating type filter in order to keep the intended behavior.