This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Migrate job to JsonConfig #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenriksson
commented
Aug 27, 2018
| </PackageReference> | ||
| <PackageReference Include="NuGet.Services.Logging"> | ||
| <Version>2.27.0</Version> | ||
| </PackageReference> | ||
| <PackageReference Include="NuGet.Services.Sql"> | ||
| <Version>2.27.0</Version> | ||
| <Version>2.28.0</Version> |
There was a problem hiding this comment.
Fixing warnings due to partial dependencies upgrade in a previous PR. KeyVault and Sql libraries had been updated to 2.28.0 for Validation.Common.Job, but not Jobs.Common.
| /// <summary> | ||
| /// Obsolete: replace with IcM configuration | ||
| /// </summary> | ||
| public string PagerDutyApiKey { get; set; } |
There was a problem hiding this comment.
Code still uses PagerDuty. I can remove in follow-up PR, if it's not too time consuming.
| }, | ||
|
|
||
| "SupportRequestDb": { | ||
| "ConnectionString": "Data Source=tcp:#{Deployment.Azure.Sql.SupportRequestDatabaseAddress};Initial Catalog=nuget-dev-supportrequest;User ID=$$Dev-SupportRequestDBWriter-UserName$$;Password=$$Dev-SupportRequestDBWriter-Password$$;Encrypt=True;TrustServerCertificate=False;Connection Timeout=30;" |
There was a problem hiding this comment.
Note: we don't have DEV/INT enabled on Octopus, but I'm adding config in case we want to enable or to ease testing.
I didn't want to add new DB creds to KeyVault, so these reference the existing writer credentials. This will change when AAD is configured.
chenriksson
requested review from
loic-sharma,
cristinamanum,
joelverhagen and
scottbommarito
| -VaultName "#{Deployment.Azure.KeyVault.VaultName}" ^ | ||
| -ClientId "#{Deployment.Azure.KeyVault.ClientId}" ^ | ||
| -CertificateThumbprint "#{Deployment.Azure.KeyVault.CertificateThumbprint}" ^ | ||
| -Configuration "#{Jobs.supportrequests.notifications.Configuration}" ^ |
There was a problem hiding this comment.
nit: consistent indentation
joelverhagen
approved these changes
Aug 27, 2018
joelverhagen
added a commit
that referenced
this pull request
Sep 27, 2019
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that I didn't migrate this job to JsonConfig, like other legacy jobs.
Now tracking with https://github.com/NuGet/Engineering/issues/1662, instead of https://github.com/NuGet/Engineering/issues/1612