This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Migrate CreateAzureCdnWarehouseReports to use JsonConfig #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenriksson
requested review from
joelverhagen,
agr,
loic-sharma,
shishirx34,
ryuyu,
dtivel,
skofman1 and
scottbommarito
August 7, 2018 23:15
chenriksson
force-pushed
the
chenriks-reports-config
branch
from
August 8, 2018 14:59
079d2b1
to
0187e02
Compare
dtivel
approved these changes
Aug 8, 2018
|
||
public string AzureCdnCloudStorageContainerName { get; set; } | ||
|
||
public string DataStorageAcount { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: DataStorageAcount
-> DataStorageAccount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
scottbommarito
approved these changes
Aug 8, 2018
chenriksson
force-pushed
the
chenriks-rollup-config
branch
from
August 8, 2018 20:51
5dc581c
to
ef2b695
Compare
chenriksson
force-pushed
the
chenriks-reports-config
branch
from
August 8, 2018 21:18
29c7d07
to
78bef23
Compare
joelverhagen
pushed a commit
that referenced
this pull request
Sep 27, 2019
* Search service - add resilience for AAD tenant migrations * Update comment
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
* Search service - add resilience for AAD tenant migrations * Update comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/NuGet/Engineering/issues/1560