This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Migrate Gallery.Maintenance to JsonConfig #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenriksson
force-pushed
the
chenriks-maint-config
branch
from
e09c1fd to
9b9fe95
Compare
chenriksson
requested review from
joelverhagen,
agr,
loic-sharma,
ryuyu,
cristinamanum,
skofman1,
scottbommarito and
shishirx34
joelverhagen
reviewed
Aug 6, 2018
| @@ -7,7 +7,7 @@ cd bin | |||
|
|
|||
| title #{Jobs.Gallery.Maintenance.Title} | |||
|
|
|||
| start /w Gallery.Maintenance.exe -VaultName "#{Deployment.Azure.KeyVault.VaultName}" -ClientId "#{Deployment.Azure.KeyVault.ClientId}" -CertificateThumbprint "#{Deployment.Azure.KeyVault.CertificateThumbprint}" -GalleryDatabase "#{Jobs.Gallery.Maintenance.GalleryDatabase}" -InstrumentationKey "#{Jobs.Gallery.Maintenance.InstrumentationKey}" -verbose true -Interval #{Jobs.Gallery.Maintenance.Interval} | |||
| start /w Gallery.Maintenance.exe -Configuration "#{Jobs.gallery.maintenance.Configuration}" -InstrumentationKey "#{Jobs.gallery.maintenance.InstrumentationKey}" -Interval #{Jobs.gallery.maintenance.Interval} | |||
There was a problem hiding this comment.
Can we move everything but -Configuration to the JSON?
There was a problem hiding this comment.
As part of the SQL work, the only requirement is to get connection strings into source control... to allow testing from private branch and easy rollback w/ history. Since I'm touching the job, I chose to also move job configuration to the JSON config.
I've left JobRunner configuration as-is for now. I can tackle it when I start working on job deployment updates.
agr
approved these changes
Aug 6, 2018
joelverhagen
approved these changes
Aug 7, 2018
chenriksson
force-pushed
the
chenriks-jobscommon-config
branch
from
c63684d to
1583750
Compare
chenriksson
force-pushed
the
chenriks-maint-config
branch
from
9b9fe95 to
5987d6f
Compare
joelverhagen
pushed a commit
that referenced
this pull request
Sep 27, 2019
* removed unnecessary bindings from the query. * Proper GetIconUrl implementation. Tests. * Disabled test parallelization to address race condition in tests * null checks for implementations of `IPackagePathProvider` * PR feedback
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
* removed unnecessary bindings from the query. * Proper GetIconUrl implementation. Tests. * Disabled test parallelization to address race condition in tests * null checks for implementations of `IPackagePathProvider` * PR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/NuGet/Engineering/issues/1560. Depends on #505
Status: Verified on DEV