This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
[Repository Signing] Add option to suppress repository signature extraction #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
joelverhagen,
agr,
xavierdecoster,
shishirx34,
zivkan,
ryuyu,
chenriksson,
cristinamanum,
skofman1,
scottbommarito and
zhhyu
| @@ -227,6 +231,12 @@ private static ExtractedCertificates ExtractPrimarySignatureCertificates(Context | |||
| return; | |||
| } | |||
|
|
|||
| if (type == PackageSignatureType.Repository && !_configuration.Value.ExtractRepositorySignatures) | |||
| { | |||
| _logger.LogWarning("Skipping initialization of repository signature due to configuration!"); | |||
There was a problem hiding this comment.
Do we really want a bajillion of these warnings?
There was a problem hiding this comment.
I can lower it to a regular informational log.
There was a problem hiding this comment.
Lowered to LogInformation
| @@ -22,7 +22,8 @@ | |||
| "AllowedRepositorySigningCertificates": [ | |||
| "cf7ac17ad047ecd5fdc36822031b12d4ef078b6f2b4c5e6ba41f8ff2cf4bad67" | |||
| ], | |||
| "V3ServiceIndexUrl": "https://api.nuget.org/v3/index.json" | |||
| "V3ServiceIndexUrl": "https://api.nuget.org/v3/index.json", | |||
| "ExtractRepositorySignatures": false | |||
There was a problem hiding this comment.
Commit instead of Extract?
| await _target.ExtractAsync(_packageKey, signature, _token); | ||
|
|
||
| // Assert | ||
| Assert.Equal(0, _entitiesContext.Object.PackageSignatures.Count()); |
There was a problem hiding this comment.
Maybe assert blobs are persisted, so we have expected behavior covered.
agr
approved these changes
Jul 26, 2018
joelverhagen
pushed a commit
that referenced
this pull request
Sep 27, 2019
Added HSTS header, removed the 'X-Powered-By'
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
Added HSTS header, removed the 'X-Powered-By'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.