This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
[ReleasePrep][2018.07.16]RI of dev into master #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SubscriptionProcessor is now set up to use ScopedMessageHandler by default, so that individual jobs don't have to do same setup over and over. * Added specific check for the case when `ISubscriptionProcessor<T>` is not configured in the DI, suggesting to use the default setup from `SubcriptionProcessorJob<T>`. Update jobs code to include a call to that helper method.
…nges (#478) * Updated to the latest version of NuGet.Services.* in Orchestrator and ProcessSignature jobs. Updated appropriate telemetry services to implement ISubscriptionProcessorTelemetryService and updated DI settings to enable instantiating proper implementations. * Nuspec update to fix failed test * Updated the missed job. Added MessageType dimension. * Prefixed all validate certificate metrics
Adds the core logic of the revalidation job so that it wakes up, determines the next package to revalidate, and enqueues it to the Orchestrator. Addresses https://github.com/NuGet/Engineering/issues/1443
…#479) * Update the GalleryCore and NuGet.Services.Validation in orchestrator.
* MaxConcurrentCalls update. * Test and configuration update * Updated int and prod settings for the ProcessSignature and ValidateCertificate jobs.
agr
approved these changes
Jul 16, 2018
|
I didn't get to this until after it was merged, but LGTM. |
joelverhagen
pushed a commit
that referenced
this pull request
Sep 27, 2019
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
[ReleasePrep][2018.07.16]RI of dev into master
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@agr @loic-sharma @cristinamanum