Remove file logging from RegistrationComparer now that AI logging is …

…up (#733) Make the comparison container (just a cursor) public for easy monitoring Related to NuGet/NuGetGallery#7741
NuGet · Jan 24, 2020 · 87a20a0 · 87a20a0
1 parent 92ffe4a
commit 87a20a0
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 36 deletions.
diff --git a/src/NuGet.Jobs.RegistrationComparer/HiveComparer.cs b/src/NuGet.Jobs.RegistrationComparer/HiveComparer.cs
@@ -159,7 +159,7 @@ await ParallelAsync.Repeat(
                     }
                     catch (InvalidOperationException ex)
                     {
-                        ResultWriter.WriteWarning(ex.Message);
+                        _logger.LogWarning(ex, "A comparison warning was found.");
                         continue;
                     }
 

diff --git a/src/NuGet.Jobs.RegistrationComparer/NuGet.Jobs.RegistrationComparer.csproj b/src/NuGet.Jobs.RegistrationComparer/NuGet.Jobs.RegistrationComparer.csproj
@@ -54,7 +54,6 @@
     <Compile Include="Program.cs" />
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="Properties\AssemblyInfo.*.cs" />
-    <Compile Include="ResultWriter.cs" />
   </ItemGroup>
   <ItemGroup>
     <None Include="App.config" />

diff --git a/src/NuGet.Jobs.RegistrationComparer/RegistrationComparerCollectorLogic.cs b/src/NuGet.Jobs.RegistrationComparer/RegistrationComparerCollectorLogic.cs
@@ -88,7 +88,6 @@ public async Task OnProcessBatchAsync(IEnumerable<CatalogCommitItem> items)
                         catch (Exception ex)
                         {
                             Interlocked.Increment(ref failures);
-                            ResultWriter.WriteError(ex.Message.ToString());
                             _logger.LogError(ex, "The comparison failed.");
                         }
                     });

diff --git a/src/NuGet.Jobs.RegistrationComparer/RegistrationComparerCommand.cs b/src/NuGet.Jobs.RegistrationComparer/RegistrationComparerCommand.cs
@@ -8,6 +8,7 @@
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 using Microsoft.WindowsAzure.Storage;
+using Microsoft.WindowsAzure.Storage.Blob;
 using NuGet.Services.Metadata.Catalog;
 using NuGet.Services.Metadata.Catalog.Persistence;
 using NuGet.Services.V3;
@@ -48,10 +49,11 @@ public async Task ExecuteAsync(CancellationToken token)
             _logger.LogInformation("Using cursor: {CursurUrl}", frontCursorPair.Key);
             var frontCursor = frontCursorPair.Value;
 
-            await _storageAccount
+            var container = _storageAccount
                 .CreateCloudBlobClient()
-                .GetContainerReference(_options.Value.StorageContainer)
-                .CreateIfNotExistsAsync();
+                .GetContainerReference(_options.Value.StorageContainer);
+            await container.CreateIfNotExistsAsync();
+            await container.SetPermissionsAsync(new BlobContainerPermissions { PublicAccess = BlobContainerPublicAccessType.Blob });
 
             await frontCursor.LoadAsync(token);
             await backCursor.LoadAsync(token);

diff --git a/src/NuGet.Jobs.RegistrationComparer/ResultWriter.cs b/src/NuGet.Jobs.RegistrationComparer/ResultWriter.cs