Speed up the revalidation job by the batch size (#675)

Currently, the job will increase its revalidation rate by 1 revalidation per hour each time it enqueues a batch of revalidations. As a result, the job speeds up very slowly. This change makes the job increase its revalidation rate by the batch size. Meaning, the revalidation job will increase its revalidation rate by 64 revalidations per hour if it enqueues 64 revalidations.
NuGet · Nov 20, 2018 · 8459db8 · 8459db8
1 parent 5296038
commit 8459db8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/NuGet.Services.Revalidate/Services/RevalidationJobStateService.cs b/src/NuGet.Services.Revalidate/Services/RevalidationJobStateService.cs
@@ -104,7 +104,8 @@ await _state.MaybeUpdateStateAsync(state =>
                     return false;
                 }
 
-                var nextRate = Math.Min(_config.MaxPackageEventRate, state.DesiredPackageEventRate + 1);
+                var nextRate = state.DesiredPackageEventRate + _config.Queue.MaxBatchSize;
+                nextRate = Math.Min(_config.MaxPackageEventRate, nextRate);
 
                 _logger.LogInformation(
                     "Increasing desired package event rate to {ToRate} from {FromRate}",

diff --git a/tests/NuGet.Services.Revalidate.Tests/Services/RevalidationJobStateServiceFacts.cs b/tests/NuGet.Services.Revalidate.Tests/Services/RevalidationJobStateServiceFacts.cs
@@ -183,7 +183,7 @@ public async Task IncreasesDesiredPackageEventRateValue()
                 await _target.IncreaseDesiredPackageEventRateAsync();
 
                 // Assert
-                Assert.Equal(124, state.DesiredPackageEventRate);
+                Assert.Equal(143, state.DesiredPackageEventRate);
                 Assert.True(result);
 
                 _state.Verify(s => s.MaybeUpdateStateAsync(It.IsAny<Func<RevalidationState, bool>>()), Times.Once);
@@ -261,6 +261,11 @@ public FactsBase()
                 {
                     MinPackageEventRate = 100,
                     MaxPackageEventRate = 500,
+
+                    Queue = new RevalidationQueueConfiguration
+                    {
+                        MaxBatchSize = 20
+                    }
                 };
 
                 _target = new RevalidationJobStateService(