Code path for getting package metadata calls into CreateCacheFileAsync while running on the UI thread #4739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jebriede
changed the title
nkolev92
previously approved these changes
Jul 27, 2022
src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageManagerControl.xaml.cs
Outdated
Show resolved
Hide resolved
jebriede
changed the title
jebriede
changed the title
zivkan
approved these changes
Jul 29, 2022
nkolev92
approved these changes
Jul 29, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/1767
Regression? Last working version: N/A
Description
One particular code path was transitioning to the UI thread while getting package metadata because it needed access to the UI property for the selected package source. Rather than transitioning to the UI thread for each package, we cache the selected package source and pass it as an argument before getting off the UI thread, so we don't need to transition back each time.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Automated tests added
OR
Manually tested the scenario of loading packages in the PMUI browse tab and installing and uninstalling a package. Also verified with a PerfView trace that this particular code path is no longer running on the UI thread.
Test exception
OR
N/A
Documentation